fix: use GORELEASER_CURRENT_TAG for RC release detection#26
Merged
pjcdawkins merged 3 commits intomainfrom Mar 12, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes release/RC detection in CI by sourcing the version from GORELEASER_CURRENT_TAG (provided by GitHub Actions) instead of relying on git describe in shallow checkouts, and tightens the Cloudsmith upload script’s shell safety settings.
Changes:
- Update
Makefileversion resolution to preferGORELEASER_CURRENT_TAG, with a git-based fallback. - Add a bash shebang and strict-mode error handling (
set -euo pipefail) tocloudsmith.sh.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
Makefile |
Adjusts how VERSION is derived to avoid shallow-checkout git describe pitfalls and improve RC detection behavior. |
cloudsmith.sh |
Adds bash strict mode to make Cloudsmith uploads fail fast on errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
pjcdawkins
approved these changes
Mar 12, 2026
pjcdawkins
deleted the
cli-114-fix-cloudsmith-execution-on-release-candidate-releases
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes RC release builds by ensuring the Makefile correctly detects pre-release versions and skips Cloudsmith uploads.
Changes
names in shallow checkouts
Result
RC releases (e.g., v5.10.0-rc1) now properly skip Cloudsmith uploads instead of failing when attempting to run the upload script.